server: fix nfs version option during mounts #9559

shwstppr · 2024-08-21T07:15:30Z

Description

Fixes #9469

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2024-08-21T07:25:03Z

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 15.08%. Comparing base (b4325ec) to head (3445407).
Report is 35 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...om/cloud/upgrade/SystemVmTemplateRegistration.java	0.00%	24 Missing ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java	0.00%	4 Missing ⚠️
...cloudstack/diagnostics/DiagnosticsServiceImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9559      +/-   ##
============================================
- Coverage     15.08%   15.08%   -0.01%     
- Complexity    11185    11187       +2     
============================================
  Files          5406     5406              
  Lines        473123   473143      +20     
  Branches      61313    60436     -877     
============================================
- Hits          71378    71374       -4     
- Misses       393805   393828      +23     
- Partials       7940     7941       +1

Flag	Coverage Δ
uitests	`4.30% <ø> (ø)`
unittests	`15.80% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java

weizhouapache · 2024-08-22T07:21:03Z

@blueorangutan package

blueorangutan · 2024-08-22T07:22:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-22T08:15:07Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10743

Fixes apache#9469 Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr · 2024-08-29T12:05:48Z

@blueorangutan package

blueorangutan · 2024-08-29T12:08:05Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-29T13:05:20Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10867

shwstppr · 2024-09-03T10:06:19Z

@blueorangutan package

blueorangutan · 2024-09-03T10:08:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-03T11:08:47Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10926

shwstppr · 2024-09-03T11:19:07Z

@blueorangutan test

blueorangutan · 2024-09-03T11:20:04Z

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-09-04T01:11:47Z

[SF] Trillian test result (tid-11312)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47686 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9559-t11312-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	`Error`	134.49	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	134.49	test_vm_life_cycle.py

abh1sar

LGTM. Didn't test.

sureshanaparti

clgtm

weizhouapache

code lgtm

DaanHoogland · 2024-09-06T06:51:24Z

@blueorangutan package

blueorangutan · 2024-09-06T06:52:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-06T08:08:36Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11029

DaanHoogland · 2024-09-06T09:07:22Z

@blueorangutan test

blueorangutan · 2024-09-06T09:08:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-09-06T23:05:51Z

[SF] Trillian test result (tid-11401)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47750 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9559-t11401-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_secured_to_nonsecured_vm_migration	`Error`	393.96	test_vm_life_cycle.py

DaanHoogland · 2024-09-09T07:06:06Z

@JoaoJandre this looks like a good to have for 4.20 (and 4.19) can you concur?

JoaoJandre · 2024-09-09T13:53:31Z

@JoaoJandre this looks like a good to have for 4.20 (and 4.19) can you concur?

@DaanHoogland yes but it seems that no one tested the PR (yet). If we can get some manual tests on it before the freeze I think it should be in 4.20

DaanHoogland · 2024-09-09T14:29:26Z

@JoaoJandre this looks like a good to have for 4.20 (and 4.19) can you concur?

@DaanHoogland yes but it seems that no one tested the PR (yet). If we can get some manual tests on it before the freeze I think it should be in 4.20

trying to fit it in @JoaoJandre ;)

DaanHoogland · 2024-09-20T08:13:02Z

engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java

+    public static String getMountCommand(String nfsVersion, String device, String dir) {
+        String cmd = "sudo mount -t nfs";
+        if (StringUtils.isNotBlank(nfsVersion)) {
+            cmd = String.format("%s -o vers=%s", cmd, nfsVersion);
+        }
+        return String.format("%s %s %s", cmd, device, dir);
+    }
+


this looks like a good generic method for creating the mount command, but it is in SystemVmTemplateRegistration. Does it make sense to move it to a utility and search for other places to use this, @shwstppr ? (some deduplication may be resulting)

DaanHoogland · 2024-09-20T08:14:54Z

@JoaoJandre this looks like a good to have for 4.20 (and 4.19) can you concur?

@DaanHoogland yes but it seems that no one tested the PR (yet). If we can get some manual tests on it before the freeze I think it should be in 4.20

trying to fit it in @JoaoJandre ;)

This got a bit behind in priority, need to create an env that doesn't support nfsv3 to do a functional test.

DaanHoogland · 2024-09-25T14:39:39Z

Tested according to the initial issue:

registering a template as system vm works and
retrieving diagnostics data as well!

Signed-off-by: Abhishek Kumar <[email protected]>

boring-cyborg bot added the component:storage label Aug 21, 2024

shwstppr mentioned this pull request Aug 21, 2024

secstorage.nfs.version is not used in two scenarios #9469

Closed

weizhouapache reviewed Aug 21, 2024

View reviewed changes

engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java Show resolved Hide resolved

engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java Outdated Show resolved Hide resolved

shwstppr linked an issue Aug 22, 2024 that may be closed by this pull request

secstorage.nfs.version is not used in two scenarios #9469

Closed

shwstppr changed the title ~~server: fix nfs version option during mount~~ server: fix nfs version option during mounts Aug 23, 2024

server: fix nfs version option during mount

3445407

Fixes apache#9469 Signed-off-by: Abhishek Kumar <[email protected]>

shwstppr force-pushed the fix-nfsversion-ops branch from 691c3b7 to 3445407 Compare August 29, 2024 12:01

apache deleted a comment from blueorangutan Aug 29, 2024

shwstppr marked this pull request as ready for review September 4, 2024 05:57

rohityadavcloud added this to the 4.19.2.0 milestone Sep 4, 2024

rohityadavcloud requested a review from abh1sar September 4, 2024 06:29

abh1sar approved these changes Sep 5, 2024

View reviewed changes

DaanHoogland added the status:needs-testing label Sep 5, 2024

rohityadavcloud requested review from DaanHoogland, sureshanaparti, GutoVeronezi and weizhouapache September 5, 2024 17:21

sureshanaparti approved these changes Sep 5, 2024

View reviewed changes

weizhouapache reviewed Sep 5, 2024

View reviewed changes

weizhouapache approved these changes Sep 5, 2024

View reviewed changes

rohityadavcloud assigned DaanHoogland Sep 17, 2024

rohityadavcloud approved these changes Sep 17, 2024

View reviewed changes

DaanHoogland reviewed Sep 20, 2024

View reviewed changes

DaanHoogland removed the status:needs-testing label Sep 25, 2024

DaanHoogland merged commit 53aa921 into apache:4.19 Sep 25, 2024
25 of 26 checks passed

DaanHoogland deleted the fix-nfsversion-ops branch September 25, 2024 14:47

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 14, 2024

server: fix nfs version option during mount (apache#9559)

dd465a3

Signed-off-by: Abhishek Kumar <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

server: fix nfs version option during mounts #9559

server: fix nfs version option during mounts #9559

shwstppr commented Aug 21, 2024

codecov bot commented Aug 21, 2024 •

edited

Loading

weizhouapache commented Aug 22, 2024

blueorangutan commented Aug 22, 2024

blueorangutan commented Aug 22, 2024

shwstppr commented Aug 29, 2024

blueorangutan commented Aug 29, 2024

blueorangutan commented Aug 29, 2024

shwstppr commented Sep 3, 2024

blueorangutan commented Sep 3, 2024

blueorangutan commented Sep 3, 2024

shwstppr commented Sep 3, 2024

blueorangutan commented Sep 3, 2024

blueorangutan commented Sep 4, 2024

abh1sar left a comment

sureshanaparti left a comment

weizhouapache left a comment

DaanHoogland commented Sep 6, 2024

blueorangutan commented Sep 6, 2024

blueorangutan commented Sep 6, 2024

DaanHoogland commented Sep 6, 2024

blueorangutan commented Sep 6, 2024

blueorangutan commented Sep 6, 2024

DaanHoogland commented Sep 9, 2024

JoaoJandre commented Sep 9, 2024

DaanHoogland commented Sep 9, 2024

DaanHoogland Sep 20, 2024

DaanHoogland commented Sep 20, 2024

DaanHoogland commented Sep 25, 2024 •

edited

Loading

server: fix nfs version option during mounts #9559

server: fix nfs version option during mounts #9559

Conversation

shwstppr commented Aug 21, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov bot commented Aug 21, 2024 • edited Loading

Codecov Report

weizhouapache commented Aug 22, 2024

blueorangutan commented Aug 22, 2024

blueorangutan commented Aug 22, 2024

shwstppr commented Aug 29, 2024

blueorangutan commented Aug 29, 2024

blueorangutan commented Aug 29, 2024

shwstppr commented Sep 3, 2024

blueorangutan commented Sep 3, 2024

blueorangutan commented Sep 3, 2024

shwstppr commented Sep 3, 2024

blueorangutan commented Sep 3, 2024

blueorangutan commented Sep 4, 2024

abh1sar left a comment

Choose a reason for hiding this comment

sureshanaparti left a comment

Choose a reason for hiding this comment

weizhouapache left a comment

Choose a reason for hiding this comment

DaanHoogland commented Sep 6, 2024

blueorangutan commented Sep 6, 2024

blueorangutan commented Sep 6, 2024

DaanHoogland commented Sep 6, 2024

blueorangutan commented Sep 6, 2024

blueorangutan commented Sep 6, 2024

DaanHoogland commented Sep 9, 2024

JoaoJandre commented Sep 9, 2024

DaanHoogland commented Sep 9, 2024

DaanHoogland Sep 20, 2024

Choose a reason for hiding this comment

DaanHoogland commented Sep 20, 2024

DaanHoogland commented Sep 25, 2024 • edited Loading

codecov bot commented Aug 21, 2024 •

edited

Loading

DaanHoogland commented Sep 25, 2024 •

edited

Loading